components/nacl/loader/nacl_trusted_listener.h - Issue 439713002: Refactoring: Split NaClListener into two delegated classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nacl_trusted_listener.h

Issue 439713002: Refactoring: Split NaClListener into two delegated classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase and redesign based on Mark's comment. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/loader/nacl_trusted_listener.h

diff --git a/components/nacl/loader/nacl_trusted_listener.h b/components/nacl/loader/nacl_trusted_listener.h

index 4819e05f5934562f36c716bf010d6e6ca08313e1..bb66b42a3e5e6a50065048132d768f1e98287275 100644

--- a/components/nacl/loader/nacl_trusted_listener.h

+++ b/components/nacl/loader/nacl_trusted_listener.h

@@ -20,9 +20,7 @@ class NaClTrustedListener : public base::RefCounted<NaClTrustedListener>,

NaClTrustedListener(const IPC::ChannelHandle& handle,

base::SingleThreadTaskRunner* ipc_task_runner);

-#if defined(OS_POSIX)

- int TakeClientFileDescriptor();

-#endif

+ IPC::ChannelHandle TakeClientChannelHandle();

// Listener implementation.

virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;

@@ -33,6 +31,7 @@ class NaClTrustedListener : public base::RefCounted<NaClTrustedListener>,

private:

friend class base::RefCounted<NaClTrustedListener>;

virtual ~NaClTrustedListener();

+ IPC::ChannelHandle channel_handle_;

scoped_ptr<IPC::ChannelProxy> channel_proxy_;

DISALLOW_COPY_AND_ASSIGN(NaClTrustedListener);