Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1820)

Unified Diff: components/nacl.gyp

Issue 439713002: Refactoring: Split NaClListener into two delegated classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl.gyp
diff --git a/components/nacl.gyp b/components/nacl.gyp
index a9933cad5a19654dd229878f17971b3772c0bd89..123fdef8f045d57abfcb41fd1e7e4e3594a82468 100644
--- a/components/nacl.gyp
+++ b/components/nacl.gyp
@@ -27,6 +27,7 @@
# .cc, .h, and .mm files under nacl that are used on all
# platforms, including both 32-bit and 64-bit Windows.
# Test files are also not included.
+ 'nacl/loader/listener_delegate.h',
Mark Seaborn 2014/08/07 00:50:20 Nit: doesn't follow the "nacl_*" naming scheme. T
'nacl/loader/nacl_ipc_adapter.cc',
'nacl/loader/nacl_ipc_adapter.h',
'nacl/loader/nacl_main.cc',
@@ -41,6 +42,8 @@
'nacl/loader/nacl_validation_db.h',
'nacl/loader/nacl_validation_query.cc',
'nacl/loader/nacl_validation_query.h',
+ 'nacl/loader/sfi_listener_delegate.cc',
Mark Seaborn 2014/08/07 00:50:20 Hmm, using "sfi_" would be a new naming scheme. O
+ 'nacl/loader/sfi_listener_delegate.h',
],
# TODO(gregoryd): consider switching NaCl to use Chrome OS defines
'conditions': [
@@ -238,6 +241,8 @@
'sources': [
'nacl/loader/nacl_helper_linux.cc',
'nacl/loader/nacl_helper_linux.h',
+ 'nacl/loader/nonsfi_listener_delegate.cc',
Mark Seaborn 2014/08/07 00:50:20 Shouldn't this go in the loader/nonsfi/ subdir for
+ 'nacl/loader/nonsfi_listener_delegate.h',
],
'dependencies': [
'nacl_linux',
« no previous file with comments | « no previous file | components/nacl/loader/listener_delegate.h » ('j') | components/nacl/loader/sfi_listener_delegate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698