Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: tools/metrics/actions/extract_actions.py

Issue 439683002: Remove old SBInterstitial counter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated suffix comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/metrics/actions/actions.xml ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/actions/extract_actions.py
diff --git a/tools/metrics/actions/extract_actions.py b/tools/metrics/actions/extract_actions.py
index 68e6faf16c8a0e895c1585b3ba345939c55ee538..7fd74466e5e2de27347a84e5c85f781b33840204 100755
--- a/tools/metrics/actions/extract_actions.py
+++ b/tools/metrics/actions/extract_actions.py
@@ -53,7 +53,6 @@ KNOWN_COMPUTED_USERS = (
'user_metrics.cc', # method definition
'new_tab_ui.cc', # most visited clicks 1-9
'extension_metrics_module.cc', # extensions hook for user metrics
- 'safe_browsing_blocking_page.cc', # various interstitial types and actions
'language_options_handler_common.cc', # languages and input methods in CrOS
'cros_language_options_handler.cc', # languages and input methods in CrOS
'about_flags.cc', # do not generate a warning; see AddAboutFlagsActions()
@@ -152,11 +151,6 @@ def AddComputedActions(actions):
for i in range(1, 10):
actions.add('MostVisited%d' % i)
- # Actions for safe_browsing_blocking_page.cc.
- for interstitial in ('Phishing', 'Malware', 'Multiple'):
- for action in ('Show', 'Proceed', 'DontProceed', 'ForcedDontProceed'):
- actions.add('SBInterstitial%s%s' % (interstitial, action))
-
# Actions for language_options_handler.cc (Chrome OS specific).
for input_method_id in INPUT_METHOD_IDS:
actions.add('LanguageOptions_DisableInputMethod_%s' % input_method_id)
« no previous file with comments | « tools/metrics/actions/actions.xml ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698