Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 439683002: Remove old SBInterstitial counter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated suffix comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/actions/actions.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
index 3bab81918b336bdb591ca1dde1c97f45350b95a2..6d111dd6283272d57761f3945d799fbae7ce519f 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
@@ -673,41 +673,6 @@ void SafeBrowsingBlockingPage::RecordUserAction(BlockingPageEvent event) {
}
}
}
-
- // TODO(felt): Get rid of the old interstitial histogram.
- std::string action = "SBInterstitial";
- switch (interstitial_type_) {
- case TYPE_MALWARE_AND_PHISHING:
- action.append("Multiple");
- break;
- case TYPE_MALWARE:
- action.append("Malware");
- break;
- case TYPE_PHISHING:
- action.append("Phishing");
- break;
- }
-
- switch (event) {
- case SHOW:
- action.append("Show");
- break;
- case PROCEED:
- action.append("Proceed");
- break;
- case DONT_PROCEED:
- if (IsPrefEnabled(prefs::kSafeBrowsingProceedAnywayDisabled))
- action.append("ForcedDontProceed");
- else
- action.append("DontProceed");
- break;
- case SHOW_ADVANCED:
- break;
- default:
- NOTREACHED() << "Unexpected event: " << event;
- }
-
- content::RecordComputedAction(action);
}
void SafeBrowsingBlockingPage::RecordUserReactionTime(
« no previous file with comments | « no previous file | tools/metrics/actions/actions.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698