Remove old SBInterstitial counter

chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Implementation of the SafeBrowsingBlockingPage class.
 
 #include "chrome/browser/safe_browsing/safe_browsing_blocking_page.h"
 
 #include <string>
 
@@ skipping 655 matching lines @@
     if (unsafe_resources_[0].is_subresource &&
         interstitial_type_ != TYPE_MALWARE_AND_PHISHING) {
       RecordDetailedUserAction((interstitial_type_ == TYPE_MALWARE) ?
           MALWARE_SHOW_CROSS_SITE : PHISHING_SHOW_CROSS_SITE);
       if (event == PROCEED) {
         RecordDetailedUserAction((interstitial_type_ == TYPE_MALWARE) ?
             MALWARE_PROCEED_CROSS_SITE : PHISHING_PROCEED_CROSS_SITE);
       }
     }
   }
-
-  // TODO(felt): Get rid of the old interstitial histogram.
-  std::string action = "SBInterstitial";
-  switch (interstitial_type_) {
-    case TYPE_MALWARE_AND_PHISHING:
-      action.append("Multiple");
-      break;
-    case TYPE_MALWARE:
-      action.append("Malware");
-      break;
-    case TYPE_PHISHING:
-      action.append("Phishing");
-      break;
-  }
-
-  switch (event) {
-    case SHOW:
-      action.append("Show");
-      break;
-    case PROCEED:
-      action.append("Proceed");
-      break;
-    case DONT_PROCEED:
-      if (IsPrefEnabled(prefs::kSafeBrowsingProceedAnywayDisabled))
-        action.append("ForcedDontProceed");
-      else
-        action.append("DontProceed");
-      break;
-    case SHOW_ADVANCED:
-      break;
-    default:
-      NOTREACHED() << "Unexpected event: " << event;
-  }
-
-  content::RecordComputedAction(action);

[mattm, 2014/08/04 20:26:06]

This is not technically a histogram. (It's under the "counts" section of the uma
dashboard. The "SBInterstitial" also showing up in histogram_suffixes is
coincidental.) It's not only relevant to the v1 interstitial, it's just old.

Probably still want to get rid of it since the more useful actual histograms
SB2.InterstitialAction / SB2.InterstitialActionDetails also exist, but it
doesn't quite match the CL description.

 }
 
 void SafeBrowsingBlockingPage::RecordUserReactionTime(
     const std::string& command) {
   if (interstitial_show_time_.is_null())
     return;  // We already reported the user reaction time.
   base::TimeDelta dt = base::TimeTicks::Now() - interstitial_show_time_;
   DVLOG(1) << "User reaction time for command:" << command
            << " on interstitial_type_:" << interstitial_type_
            << " warning took " << dt.InMilliseconds() << "ms";
@@ skipping 470 matching lines @@
           IDS_PHISHING_V3_PRIMARY_PARAGRAPH,
           base::UTF8ToUTF16(url_.host())));
   load_time_data->SetString(
       "explanationParagraph",
       l10n_util::GetStringFUTF16(IDS_PHISHING_V3_EXPLANATION_PARAGRAPH,
                                  base::UTF8ToUTF16(url_.host())));
   load_time_data->SetString(
       "finalParagraph",
       l10n_util::GetStringUTF16(IDS_PHISHING_V3_PROCEED_PARAGRAPH));
 }