Issue 439673002: athena: Make some UI changes to the home-card bottom-view to match the mocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 439673002: athena: Make some UI changes to the home-card bottom-view to match the mocks. (Closed)

Created:
6 years, 4 months ago by sadrul

Modified:
6 years, 4 months ago

Reviewers:
Jun Mukai, sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

athena: Make some UI changes to the home-card bottom-view to match the mocks. . Add a shadow around the bottom-view of the home-card. . Make the background slightly transparent. . Make the bottom-view slightly narrower. . Remove the borders around the apps. BUG=none R=mukai@chromium.org TBR=sky@chromium.org for DEPS on ui/gfx/ from athena/home Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287535

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -8 lines)			Patch
M	athena/home/DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	athena/home/bottom_home_view.cc	View	2 chunks	+42 lines, -4 lines	0 comments	Download
M	athena/home/home_card_impl.cc	View	6 chunks	+24 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sadrul

+sky@ for ui/gfx/ DEPS addition (instead of just ui/gfx/image)

6 years, 4 months ago (2014-08-05 13:57:50 UTC) #3

sadrul

6 years, 4 months ago (2014-08-05 13:58:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as 287535 (presubmit successful).

Expand Messages | Collapse Messages