tools/telemetry/telemetry/value/failure.py - Issue 439613003: Add Chart JSON processing to Telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/value/failure.py

Issue 439613003: Add Chart JSON processing to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address most of Nat's comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/value/failure.py

diff --git a/tools/telemetry/telemetry/value/failure.py b/tools/telemetry/telemetry/value/failure.py

index ba6998ad4b4c6c22c0c18f03ae2fb6b11c1f4779..66675b304ee6a32b668307ddf9444a46db1dc00d 100644

--- a/tools/telemetry/telemetry/value/failure.py

+++ b/tools/telemetry/telemetry/value/failure.py

@@ -57,7 +57,7 @@ class FailureValue(value_module.Value):

def GetBuildbotValue(self):

return None

- def GetBuildbotMeasurementAndTraceNameForPerPageResult(self):

+ def GetChartAndTraceNameForPerPageResult(self):

return None

def GetRepresentativeNumber(self):