Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 439613002: fix libgio-2.0 deps in browser_ui (Closed)

Created:
6 years, 4 months ago by Mostyn Bramley-Moore
Modified:
6 years, 4 months ago
Reviewers:
Elliot Glaysher, sky
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

fix libgio-2.0 deps in browser_ui browser_desktop_root_window_host_x11.cc uses g_dbus_proxy_call which is provided by libgio-2.0, so we should depend on the gio target too. BUG=265560 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287981

Patch Set 1 #

Patch Set 2 : use gio target instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/chrome_browser_ui.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mostyn Bramley-Moore
@Elliot, sky: please take a look at this small fixup, related to https://chromiumcodereview.appspot.com/22455002
6 years, 4 months ago (2014-08-02 21:27:17 UTC) #1
Mostyn Bramley-Moore
Hmm, wait- there's a gio target that should be used instead (fixed in patch set ...
6 years, 4 months ago (2014-08-02 21:44:49 UTC) #2
Elliot Glaysher
lgtm
6 years, 4 months ago (2014-08-05 17:57:12 UTC) #3
Mostyn Bramley-Moore
@sky: *ping* for OWNERS approval
6 years, 4 months ago (2014-08-06 20:48:30 UTC) #4
sky
LGTM
6 years, 4 months ago (2014-08-06 21:23:24 UTC) #5
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 4 months ago (2014-08-06 21:32:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/439613002/20001
6 years, 4 months ago (2014-08-06 21:34:08 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-07 03:06:21 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 07:16:52 UTC) #9
Message was sent while issue was closed.
Change committed as 287981

Powered by Google App Engine
This is Rietveld 408576698