Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 439543002: Convert libexif.gyp to new clang flags after r287092. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
hans, tommycli
CC:
chromium-reviews, tommycli
Project:
chromium
Visibility:
Public.

Description

Convert libexif.gyp to new clang flags after r287092. BUG=none R=hans@chromium.org TBR=cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287132

Patch Set 1 #

Patch Set 2 : with wno-format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M third_party/libexif/libexif.gyp View 1 1 chunk +9 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
6 years, 4 months ago (2014-08-01 22:13:40 UTC) #1
Nico
Removing -Wno-format didn't work. It's now added on all platforms instead.
6 years, 4 months ago (2014-08-01 22:19:17 UTC) #2
hans
lgtm
6 years, 4 months ago (2014-08-01 23:32:46 UTC) #3
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-01 23:46:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/439543002/20001
6 years, 4 months ago (2014-08-01 23:48:47 UTC) #5
Nico
Committed patchset #2 manually as 287132 (presubmit successful).
6 years, 4 months ago (2014-08-02 00:31:22 UTC) #6
tommycli
6 years, 4 months ago (2014-08-04 16:41:20 UTC) #7
Message was sent while issue was closed. 
thank you!

Powered by Google App Engine
This is Rietveld 408576698