Port most sync targets to sync/BUILD.gn

Port most sync targets to sync/BUILD.gn

Ports most of the sync GYP targets to GN.  Adds comments in the original
GYP files pointing to the new GN targets.  Fixes some TODOs in other
files that were blocked on sync GN support.

Adds several new linkable targets to the GN build.

The android-specific parts of sync have not been converted yet.

TBR=nyquist,rogerta
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287905

[rlarocque, 2014-08-04 17:52:09]

Here's the patch to support building sync with GN on Linux.  I'll try to convert
the android parts in a separate CL.

+Brett for review of the GN files.
+Pavel for review of a few trivial changes to non-GN files.

https://codereview.chromium.org/439533004/diff/1/components/invalidation/BUIL...
File components/invalidation/BUILD.gn (left):

https://codereview.chromium.org/439533004/diff/1/components/invalidation/BUIL...
components/invalidation/BUILD.gn:135:
#'../sync/sync.gyp:test_support_sync_notifier',  TODO(GYP)
This target became obsolete with r283840.

[pavely, 2014-08-04 18:31:37]

lgtm

[brettw, 2014-08-04 18:33:39]

lgtm

[rlarocque, 2014-08-04 18:37:48]

The CQ bit was checked by rlarocque@chromium.org

[commit-bot: I haz the power, 2014-08-04 18:39:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rlarocque@chromium.org/439533004/1

[commit-bot: I haz the power, 2014-08-04 21:09:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-08-04 21:13:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-04 21:13:01]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rlarocque, 2014-08-04 21:27:01]

That's odd.  The presubmit scripts and the chromite butler disagree about
whether or not all files in this change have an owner LGTM.

TBR'ing Tommy and Roger for trivial changes to GN files in directories that they
own.

[rlarocque, 2014-08-04 21:27:22]

The CQ bit was checked by rlarocque@chromium.org

[commit-bot: I haz the power, 2014-08-04 21:28:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rlarocque@chromium.org/439533004/1

[commit-bot: I haz the power, 2014-08-05 04:14:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-05 04:14:28]

Failed to apply patch for components/invalidation/BUILD.gn:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file components/invalidation/BUILD.gn
  Hunk #1 FAILED at 132.
  1 out of 1 hunk FAILED -- saving rejects to file
components/invalidation/BUILD.gn.rej

Patch:       components/invalidation/BUILD.gn
Index: components/invalidation/BUILD.gn
diff --git a/components/invalidation/BUILD.gn b/components/invalidation/BUILD.gn
index
fd6773a505d965b27741597c6254f28a626a8e68..277aa253abbee4c604564dadc18247d60cc3f2d3
100644
--- a/components/invalidation/BUILD.gn
+++ b/components/invalidation/BUILD.gn
@@ -132,7 +132,6 @@ static_library("test_support") {
     "//third_party/cacheinvalidation",
     #'../jingle/jingle.gyp:notifier',  TODO(GYP)
     #'../jingle/jingle.gyp:notifier_test_util',  TODO(GYP)
-    #'../sync/sync.gyp:test_support_sync_notifier',  TODO(GYP)
     #'gcm_driver_test_support',  TODO(GYP)
   ]
 }

[rlarocque, 2014-08-05 17:50:07]

It conflicted with my own jingle GN patch.  :(

Fixed the conflict, rebased, and re-uploaded.

[rlarocque, 2014-08-05 17:50:12]

The CQ bit was checked by rlarocque@chromium.org

[commit-bot: I haz the power, 2014-08-05 17:51:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rlarocque@chromium.org/439533004/20001

[commit-bot: I haz the power, 2014-08-05 21:43:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-05 23:08:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-05 23:08:15]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rlarocque, 2014-08-06 19:58:48]

The CQ bit was checked by rlarocque@chromium.org

[commit-bot: I haz the power, 2014-08-06 20:00:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rlarocque@chromium.org/439533004/40001

[nyquist, 2014-08-06 20:05:32]

lgtm

[commit-bot: I haz the power, 2014-08-07 00:05:25]

Change committed as 287905