Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 439513003: Improve GN value origins for error messages. (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
6 years, 4 months ago
Reviewers:
awong
CC:
chromium-reviews, tfarina, erikwright+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Improve GN value origins for error messages. Sets the origin for a value when the value is dereferenced. Previously if you did foo = 6 deps = [ foo ] You would get the message: ERROR at //BUILD.gn:15:9: This is not a string. foo = 6 ^ Which in this case is pretty confusing since that's obviously the case, and you really want to know where it was dereferenced. With this patch the message is: ERROR at //BUILD.gn:21:5: This is not a string. foo, ^-- Instead I see a integer = 6 which is more actionable. R=ajwong@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288131

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -5 lines) Patch
M tools/gn/parse_tree.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M tools/gn/parse_tree_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M tools/gn/value.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 4 months ago (2014-08-02 21:25:58 UTC) #1
awong
LGTM Nice!
6 years, 4 months ago (2014-08-07 19:03:55 UTC) #2
brettw
6 years, 4 months ago (2014-08-07 20:11:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 288131 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698