Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 439503005: Add a landmine for the content/child/blink_platform_impl.cc IDR_* errors. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add a landmine for the content/child/blink_platform_impl.cc IDR_* errors. BUG=338338 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287102

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/get_landmines.py View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Nico
That's how this works, right? (Since I just got this on a tryjob of mine)
6 years, 4 months ago (2014-08-01 21:14:38 UTC) #1
Ken Russell (switch to Gerrit)
LGTM That's how they work AFAIK.
6 years, 4 months ago (2014-08-01 21:38:43 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-01 21:39:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/439503005/1
6 years, 4 months ago (2014-08-01 21:40:49 UTC) #4
commit-bot: I haz the power
Change committed as 287102
6 years, 4 months ago (2014-08-01 22:08:54 UTC) #5
tfarina
6 years, 4 months ago (2014-08-04 16:23:30 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/439503005/diff/1/build/get_landmines.py
File build/get_landmines.py (right):

https://codereview.chromium.org/439503005/diff/1/build/get_landmines.py#newco...
build/get_landmines.py:59: print '[chromium-dev] PSA: clobber build needed for
IDR_INSPECTOR_* compil...'
So as Jochen suggested in
https://codereview.chromium.org/423613003/diff/270001/content/app/strings/con...

I will send a PSA to chromium-dev and then add the subject line here?

Powered by Google App Engine
This is Rietveld 408576698