Issue 439503005: Add a landmine for the content/child/blink_platform_impl.cc IDR_* errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 439503005: Add a landmine for the content/child/blink_platform_impl.cc IDR_* errors. (Closed)

Created:
6 years, 4 months ago by Nico

Modified:
6 years, 4 months ago

Reviewers:
Ken Russell (switch to Gerrit), scottmg, tfarina

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add a landmine for the content/child/blink_platform_impl.cc IDR_* errors. BUG=338338 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287102

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/get_landmines.py	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nico

That's how this works, right? (Since I just got this on a tryjob of mine)

6 years, 4 months ago (2014-08-01 21:14:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/439503005/1

6 years, 4 months ago (2014-08-01 21:40:49 UTC) #4

tfarina

6 years, 4 months ago (2014-08-04 16:23:30 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/439503005/diff/1/build/get_landmines.py
File build/get_landmines.py (right):

https://codereview.chromium.org/439503005/diff/1/build/get_landmines.py#newco...
build/get_landmines.py:59: print '[chromium-dev] PSA: clobber build needed for
IDR_INSPECTOR_* compil...'
So as Jochen suggested in
https://codereview.chromium.org/423613003/diff/270001/content/app/strings/con...

I will send a PSA to chromium-dev and then add the subject line here?

Expand Messages | Collapse Messages