Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 439493002: Revert "Make the sandbox code link with the 10.7 SDK." (Closed)

Created:
6 years, 4 months ago by Avi (use Gerrit)
Modified:
6 years, 4 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Revert "Make the sandbox code link with the 10.7 SDK." This reverts commit r287000. This turns out to not help, and the proper fix is insanely complicated. Also fix some broken declarations. BUG=399414 TBR=rsesek@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M sandbox/mac/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M sandbox/mac/sandbox_mac.gypi View 2 chunks +5 lines, -5 lines 0 comments Download
M sandbox/mac/xpc_stubs.sig View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Avi (use Gerrit)
6 years, 4 months ago (2014-08-01 15:39:32 UTC) #1
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 4 months ago (2014-08-01 15:51:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/439493002/1
6 years, 4 months ago (2014-08-01 15:53:01 UTC) #3
Avi (use Gerrit)
The CQ bit was unchecked by avi@chromium.org
6 years, 4 months ago (2014-08-01 17:27:06 UTC) #4
Avi (use Gerrit)
On 2014/08/01 17:27:06, Avi wrote: > The CQ bit was unchecked by mailto:avi@chromium.org NOTRY yay ...
6 years, 4 months ago (2014-08-01 17:27:27 UTC) #5
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 4 months ago (2014-08-01 17:27:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/439493002/1
6 years, 4 months ago (2014-08-01 17:28:07 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 17:31:47 UTC) #8
Message was sent while issue was closed.
Change committed as 287034

Powered by Google App Engine
This is Rietveld 408576698