content/public/android/java/src/org/chromium/content/browser/ContentVideoViewLegacy.java - Issue 439433004: Browser goes to the previous page when exiting fullscreen via escape(esc) key of BT keyboard

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentVideoViewLegacy.java

Issue 439433004: Browser goes to the previous page when exiting fullscreen via escape(esc) key of BT keyboard (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding indentation changes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/ContentVideoViewLegacy.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentVideoViewLegacy.java b/content/public/android/java/src/org/chromium/content/browser/ContentVideoViewLegacy.java

index d628fcf24b83e97f85a720a34549d29769d14d2d..f7d1577f12f2c90d98460711efff0ae744330045 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentVideoViewLegacy.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentVideoViewLegacy.java

@@ -127,8 +127,8 @@ public class ContentVideoViewLegacy extends ContentVideoView {

} else {

toggleMediaControlsVisiblity();

}

- } else if (keyCode == KeyEvent.KEYCODE_BACK &&

- event.getAction() == KeyEvent.ACTION_UP) {

+ } else if ((keyCode == KeyEvent.KEYCODE_BACK || keyCode == KeyEvent.KEYCODE_ESCAPE)

+ && event.getAction() == KeyEvent.ACTION_UP) {

exitFullscreen(false);

return true;

} else if (keyCode == KeyEvent.KEYCODE_MENU || keyCode == KeyEvent.KEYCODE_SEARCH) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »