Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 439433003: The generated archived_results.json must have relative link to the results.html in the same folder (Closed)

Created:
6 years, 4 months ago by patro
Modified:
6 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

The generated archived_results.json must have relative link to the results.html in the same folder not absolute link. It is because the folder name is changed when layout-test-results folder is archived. It leads to incorrect links. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179612

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
patro
Kindly Review Thanks, Shyam Patro
6 years, 4 months ago (2014-08-01 11:40:36 UTC) #1
Dirk Pranke
lgtm
6 years, 4 months ago (2014-08-04 17:11:33 UTC) #2
patro
The CQ bit was checked by behara.ms@samsung.com
6 years, 4 months ago (2014-08-04 18:56:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/behara.ms@samsung.com/439433003/1
6 years, 4 months ago (2014-08-04 18:57:21 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-04 20:09:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-04 21:08:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20613)
6 years, 4 months ago (2014-08-04 21:08:10 UTC) #7
patro
The CQ bit was checked by behara.ms@samsung.com
6 years, 4 months ago (2014-08-06 13:22:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/behara.ms@samsung.com/439433003/1
6 years, 4 months ago (2014-08-06 13:22:29 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 13:58:31 UTC) #10
Message was sent while issue was closed.
Change committed as 179612

Powered by Google App Engine
This is Rietveld 408576698