Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 439393003: Add whitelist for the chrome.syncedNotificationsPrivate API. (Closed)

Created:
6 years, 4 months ago by dewittj
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add whitelist for the chrome.syncedNotificationsPrivate API. Additionally, promotes the API to dev channel since it is appropriately restricted. BUG=400436 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288109

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix indent level. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/common/extensions/api/_permission_features.json View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dewittj
ptal, thanks
6 years, 4 months ago (2014-08-04 22:05:54 UTC) #1
not at google - send to devlin
lgtm https://codereview.chromium.org/439393003/diff/1/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/439393003/diff/1/chrome/common/extensions/api/_permission_features.json#newcode963 chrome/common/extensions/api/_permission_features.json:963: "34967F9FA3C399E1EC380B443D7331AA93AC445B" // http://crbug.com/400436 indent -= 2
6 years, 4 months ago (2014-08-04 22:08:05 UTC) #2
dewittj
The CQ bit was checked by dewittj@chromium.org
6 years, 4 months ago (2014-08-05 17:05:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/439393003/20001
6 years, 4 months ago (2014-08-05 17:06:44 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 21:05:18 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 22:31:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/1373)
6 years, 4 months ago (2014-08-05 22:31:35 UTC) #7
dewittj
The CQ bit was checked by dewittj@chromium.org
6 years, 4 months ago (2014-08-07 17:12:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/439393003/20001
6 years, 4 months ago (2014-08-07 17:12:57 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 19:31:13 UTC) #10
Message was sent while issue was closed.
Change committed as 288109

Powered by Google App Engine
This is Rietveld 408576698