Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: chrome/browser/resources/history/history.js

Issue 439313004: history: remove unused variable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: estade@ review Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/history/history.js
diff --git a/chrome/browser/resources/history/history.js b/chrome/browser/resources/history/history.js
index 50b79464f73a7ca17cb4e608578e2eab3166b1de..6a987dc3b81007bfa7c73109f1764e63f117880c 100644
--- a/chrome/browser/resources/history/history.js
+++ b/chrome/browser/resources/history/history.js
@@ -1798,7 +1798,6 @@ PageState.prototype.getHashData = function() {
var result = {
q: '',
page: 0,
- grouped: false,
range: 0,
offset: 0
};
@@ -1809,9 +1808,8 @@ PageState.prototype.getHashData = function() {
var hashSplit = window.location.hash.substr(1).split('&');
for (var i = 0; i < hashSplit.length; i++) {
var pair = hashSplit[i].split('=');
- if (pair.length > 1) {
+ if (pair.length > 1)
result[pair[0]] = decodeURIComponent(pair[1].replace(/\+/g, ' '));
- }
}
return result;
@@ -1879,7 +1877,6 @@ function load() {
// Create default view.
var hashData = pageState.getHashData();
- var grouped = (hashData.grouped == 'true') || historyModel.getGroupByDomain();
Evan Stade 2014/08/04 21:50:05 I guess that it would make more sense to either us
Sergiu 2014/09/09 08:59:24 Removing this should be fine. We actually infer th
Dan Beam 2014/09/10 23:20:46 Removed the local var, left this.groupByDomain_ as
var page = parseInt(hashData.page, 10) || historyView.getPage();
var range = parseInt(hashData.range, 10) || historyView.getRangeInDays();
var offset = parseInt(hashData.offset, 10) || historyView.getOffset();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698