history: remove unused variable.

chrome/browser/resources/history/history.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="../uber/uber_utils.js">
 <include src="history_focus_manager.js">
 
 ///////////////////////////////////////////////////////////////////////////////
 // Globals:
 /** @const */ var RESULTS_PER_PAGE = 150;
@@ skipping 840 matching lines @@
  * @private
  */
 HistoryModel.prototype.canFillPage_ = function(page) {
   return ((page + 1) * RESULTS_PER_PAGE <= this.getSize());
 };
 
 /**
  * Enables or disables grouping by domain.
  * @param {boolean} groupByDomain New groupByDomain_ value.
  */
 HistoryModel.prototype.setGroupByDomain = function(groupByDomain) {

[Evan Stade, 2014/08/04 21:50:05]

it seems like this isn't used...

[Sergiu, 2014/09/09 08:59:24]

Yeah, this should be removed I guess.

[Dan Beam, 2014/09/10 23:20:46]

Done.

   this.groupByDomain_ = groupByDomain;
   this.offset_ = 0;
 };
 
 /**
  * Gets whether we are grouped by domain.
  * @return {boolean} Whether the results are grouped by domain.
  */
 HistoryModel.prototype.getGroupByDomain = function() {
   return this.groupByDomain_;
@@ skipping 919 matching lines @@
  */
 PageState.instance = null;
 
 /**
  * @return {Object} An object containing parameters from our window hash.
  */
 PageState.prototype.getHashData = function() {
   var result = {
     q: '',
     page: 0,
-    grouped: false,
     range: 0,
     offset: 0
   };
 
   if (!window.location.hash)
     return result;
 
   var hashSplit = window.location.hash.substr(1).split('&');
   for (var i = 0; i < hashSplit.length; i++) {
     var pair = hashSplit[i].split('=');
-    if (pair.length > 1) {
+    if (pair.length > 1)
       result[pair[0]] = decodeURIComponent(pair[1].replace(/\+/g, ' '));
-    }
   }
 
   return result;
 };
 
 /**
  * Set the hash to a specified state, this will create an entry in the
  * session history so the back button cycles through hash states, which
  * are then picked up by our listener.
  * @param {string} term The current search string.
@@ skipping 47 matching lines @@
   uber.onContentFrameLoaded();
 
   var searchField = $('search-field');
 
   historyModel = new HistoryModel();
   historyView = new HistoryView(historyModel);
   pageState = new PageState(historyModel, historyView);
 
   // Create default view.
   var hashData = pageState.getHashData();
-  var grouped = (hashData.grouped == 'true') || historyModel.getGroupByDomain();

[Evan Stade, 2014/08/04 21:50:05]

I guess that it would make more sense to either use this, i.e. 

  historyView.setGroupedByDomain(grouped)

or remove the grouping by domain completely.

+sergiu who seems to own this feature

[Sergiu, 2014/09/09 08:59:24]

Removing this should be fine. We actually infer the "grouped" state from the
range (you can see groupedByDomain being set in setPageState here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...).

[Dan Beam, 2014/09/10 23:20:46]

Removed the local var, left this.groupByDomain_ as it's still used.

   var page = parseInt(hashData.page, 10) || historyView.getPage();
   var range = parseInt(hashData.range, 10) || historyView.getRangeInDays();
   var offset = parseInt(hashData.offset, 10) || historyView.getOffset();
   historyView.setPageState(hashData.q, page, range, offset);
 
   if ($('overlay')) {
     cr.ui.overlay.setupOverlay($('overlay'));
     cr.ui.overlay.globalInitialization();
   }
   HistoryFocusManager.getInstance().initialize();
@@ skipping 437 matching lines @@
     historyView.reload();
 }
 
 // Add handlers to HTML elements.
 document.addEventListener('DOMContentLoaded', load);
 
 // This event lets us enable and disable menu items before the menu is shown.
 document.addEventListener('canExecute', function(e) {
   e.canExecute = true;
 });