Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 439263004: Implement lowering of JS[Load,Store][Property,Named] to ICs. (Closed)

Created:
6 years, 4 months ago by Michael Starzinger
Modified:
6 years, 4 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Implement lowering of JS[Load,Store][Property,Named] to ICs. R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22877

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -27 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 3 chunks +140 lines, -19 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Michael Starzinger
6 years, 4 months ago (2014-08-04 15:40:47 UTC) #1
titzer
https://codereview.chromium.org/439263004/diff/1/src/compiler/js-generic-lowering.cc File src/compiler/js-generic-lowering.cc (right): https://codereview.chromium.org/439263004/diff/1/src/compiler/js-generic-lowering.cc#newcode425 src/compiler/js-generic-lowering.cc:425: KeyedLoadICStubShim stub(isolate()); Do we still want to respect the ...
6 years, 4 months ago (2014-08-05 12:33:27 UTC) #2
Michael Starzinger
https://codereview.chromium.org/439263004/diff/1/src/compiler/js-generic-lowering.cc File src/compiler/js-generic-lowering.cc (right): https://codereview.chromium.org/439263004/diff/1/src/compiler/js-generic-lowering.cc#newcode425 src/compiler/js-generic-lowering.cc:425: KeyedLoadICStubShim stub(isolate()); On 2014/08/05 12:33:27, titzer wrote: > Do ...
6 years, 4 months ago (2014-08-05 12:41:38 UTC) #3
titzer
lgtm
6 years, 4 months ago (2014-08-05 13:16:41 UTC) #4
Michael Starzinger
6 years, 4 months ago (2014-08-05 13:32:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as 22877 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698