Issue 439253002: Micro-optimization in HandleVertexAttribPointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 439253002: Micro-optimization in HandleVertexAttribPointer (Closed)

Created:
6 years, 4 months ago by oetuaho-nv

Modified:
6 years, 4 months ago

Reviewers:
vmiura, piman

CC:
chromium-reviews, piman+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr

Project:
chromium

Visibility:
Public.

More Reviews

Description

Micro-optimization in HandleVertexAttribPointer vertexAttribPointer is a fairly common GL call, so substituting integer division with bitwise and which has far less latency on common CPU architectures is a worthwhile optimization. IsPOT function is added for asserts that make sure this does not break. Redundant comparison against zero is dropped from IsNPOT. In C++, unsigned integers are specified to work with mod 2^n arithmetic. TEST=gpu_unittests BUG=400135 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287512

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
	M	gpu/command_buffer/common/gles2_cmd_utils.h	View		1 chunk	+7 lines, -1 line	0 comments	Download
	M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oetuaho@nvidia.com/439253002/1

6 years, 4 months ago (2014-08-05 07:29:39 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...

6 years, 4 months ago (2014-08-05 11:23:12 UTC) #5

Message was sent while issue was closed.

Change committed as 287512

Expand Messages | Collapse Messages