Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1692)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 439243006: Disable EnableCaptureAndDisableMonitoringWithEmptyFileAndNullCallback (Closed)

Created:
6 years, 4 months ago by Michael van Ouwerkerk
Modified:
6 years, 4 months ago
Reviewers:
Peter Beverloo, nduca
CC:
chromium-reviews, darin-cc_chromium.org, dsinclair+watch_chromium.org, jam, wfh+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Disable EnableCaptureAndDisableMonitoringWithEmptyFileAndNullCallback This test is flaky on Android, so disable it there. BUG=392446 TBR=nduca@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287347

Patch Set 1 #

Total comments: 2

Patch Set 2 : Wrap long lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M content/browser/tracing/tracing_controller_browsertest.cc View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Michael van Ouwerkerk
6 years, 4 months ago (2014-08-04 14:25:32 UTC) #1
Michael van Ouwerkerk
6 years, 4 months ago (2014-08-04 14:26:31 UTC) #2
Peter Beverloo
lgtm % comment. you'll also need to TBR an OWNER https://codereview.chromium.org/439243006/diff/1/content/browser/tracing/tracing_controller_browsertest.cc File content/browser/tracing/tracing_controller_browsertest.cc (right): https://codereview.chromium.org/439243006/diff/1/content/browser/tracing/tracing_controller_browsertest.cc#newcode297 ...
6 years, 4 months ago (2014-08-04 14:27:41 UTC) #3
Michael van Ouwerkerk
https://codereview.chromium.org/439243006/diff/1/content/browser/tracing/tracing_controller_browsertest.cc File content/browser/tracing/tracing_controller_browsertest.cc (right): https://codereview.chromium.org/439243006/diff/1/content/browser/tracing/tracing_controller_browsertest.cc#newcode297 content/browser/tracing/tracing_controller_browsertest.cc:297: #define MAYBE_EnableCaptureAndDisableMonitoringWithEmptyFileAndNullCallback DISABLED_EnableCaptureAndDisableMonitoringWithEmptyFileAndNullCallback On 2014/08/04 14:27:41, Peter Beverloo wrote: ...
6 years, 4 months ago (2014-08-04 14:30:44 UTC) #4
Michael van Ouwerkerk
The CQ bit was checked by mvanouwerkerk@chromium.org
6 years, 4 months ago (2014-08-04 14:31:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/439243006/20001
6 years, 4 months ago (2014-08-04 14:32:01 UTC) #6
Michael van Ouwerkerk
The CQ bit was unchecked by mvanouwerkerk@chromium.org
6 years, 4 months ago (2014-08-04 16:19:29 UTC) #7
Michael van Ouwerkerk
The CQ bit was checked by mvanouwerkerk@chromium.org
6 years, 4 months ago (2014-08-04 16:19:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/439243006/20001
6 years, 4 months ago (2014-08-04 16:20:16 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 16:21:17 UTC) #10
Message was sent while issue was closed. 
Change committed as 287347

Powered by Google App Engine
This is Rietveld 408576698