Issue 439243005: Ensure prototypes always stay fast by turning them fast again after an operation that turned them s…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 439243005: Ensure prototypes always stay fast by turning them fast again after an operation that turned them s… (Closed)

Created:
6 years, 4 months ago by Toon Verwaest

Modified:
6 years, 4 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Ensure prototypes always stay fast by turning them fast again after an operation that turned them slow BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22827

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -34 lines)			Patch
M	src/objects.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects.cc	View	1	11 chunks	+40 lines, -19 lines	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+0 lines, -14 lines	0 comments	Download
M	test/mjsunit/dictionary-properties.js	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with a nit: https://codereview.chromium.org/439243005/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/439243005/diff/1/src/objects.cc#newcode5711 src/objects.cc:5711: ASSERT(!old_map->is_prototype_map()); I'm afraid that it ...

6 years, 4 months ago (2014-08-04 13:57:29 UTC) #2

Toon Verwaest

Updated the ASSERT to ensure that the code itself never made the object slow. It ...

6 years, 4 months ago (2014-08-04 14:02:44 UTC) #3

Toon Verwaest

6 years, 4 months ago (2014-08-04 15:06:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 22827 (presubmit successful).

Expand Messages | Collapse Messages

Issue 439243005: Ensure prototypes always stay fast by turning them fast again after an operation that turned them s… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages