Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Side by Side Diff: test/cctest/test-weakmaps.cc

Issue 439233002: Remove all encountered weak maps from the list of weak collections when incremental marking is abor… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/test-heap.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 Handle<Smi>(Smi::FromInt(i), isolate)); 248 Handle<Smi>(Smi::FromInt(i), isolate));
249 } 249 }
250 250
251 // Force compacting garbage collection. The subsequent collections are used 251 // Force compacting garbage collection. The subsequent collections are used
252 // to verify that key references were actually updated. 252 // to verify that key references were actually updated.
253 CHECK(FLAG_always_compact); 253 CHECK(FLAG_always_compact);
254 heap->CollectAllGarbage(Heap::kNoGCFlags); 254 heap->CollectAllGarbage(Heap::kNoGCFlags);
255 heap->CollectAllGarbage(Heap::kNoGCFlags); 255 heap->CollectAllGarbage(Heap::kNoGCFlags);
256 heap->CollectAllGarbage(Heap::kNoGCFlags); 256 heap->CollectAllGarbage(Heap::kNoGCFlags);
257 } 257 }
258
259
260 TEST(Regress399527) {
261 CcTest::InitializeVM();
262 v8::HandleScope scope(CcTest::isolate());
263 Isolate* isolate = CcTest::i_isolate();
264 Heap* heap = isolate->heap();
265 {
266 HandleScope scope(isolate);
267 AllocateJSWeakMap(isolate);
268 SimulateIncrementalMarking(heap);
269 }
270 // The weak map is marked black here but leaving the handle scope will make
271 // the object unreachable. Aborting incremental marking will clear all the
272 // marking bits which makes the weak map garbage.
273 heap->CollectAllGarbage(Heap::kAbortIncrementalMarkingMask);
274 }
OLDNEW
« no previous file with comments | « test/cctest/test-heap.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698