Remove all encountered weak maps from the list of weak collections when incremental marking is abor…

test/cctest/test-weakmaps.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 237 matching lines @@
                    Handle<Smi>(Smi::FromInt(i), isolate));
   }
 
   // Force compacting garbage collection. The subsequent collections are used
   // to verify that key references were actually updated.
   CHECK(FLAG_always_compact);
   heap->CollectAllGarbage(Heap::kNoGCFlags);
   heap->CollectAllGarbage(Heap::kNoGCFlags);
   heap->CollectAllGarbage(Heap::kNoGCFlags);
 }
+
+
+TEST(Regress399527) {
+  CcTest::InitializeVM();
+  v8::HandleScope scope(CcTest::isolate());
+  Isolate* isolate = CcTest::i_isolate();
+  Heap* heap = isolate->heap();
+
+  {
+    HandleScope scope(isolate);
+    Handle<JSWeakMap> weak_map = AllocateJSWeakMap(isolate);
+    IncrementalMarking* marking = heap->incremental_marking();
+    if (marking->IsStopped()) {

[Michael Starzinger, 2014/08/04 15:15:37]

Please use SimulateIncrementalMarking instead of this manual messing with
IncrementalMarking.

[Hannes Payer (out of office), 2014/08/04 15:31:44]

Done.

+      marking->Start();
+    }
+
+    while (!Marking::IsBlack(Marking::MarkBitFrom(*weak_map))) {
+      marking->Step(MB, IncrementalMarking::NO_GC_VIA_STACK_GUARD);
+    }
+  }
+  // The weak map is marked black here but leaving the handle scope will make
+  // the object unreachable. Aborting incremental marking will clear all the
+  // marking bits which makes the weak map garbage.
+  heap->CollectAllGarbage(Heap::kAbortIncrementalMarkingMask);
+}