Issue 439233002: Remove all encountered weak maps from the list of weak collections when incremental marking is abor…

Issue 439233002: Remove all encountered weak maps from the list of weak collections when incremental marking is abor… (Closed)

Created:
6 years, 4 months ago by Hannes Payer (out of office)

Modified:
6 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Remove all encountered weak maps from the list of weak collections when incremental marking is aborted. BUG=399527 LOG=n R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22844

Patch Set 5 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -36 lines)			Patch
M	src/gc-tracer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gc-tracer.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/mark-compact.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/mark-compact.cc	View		2 chunks	+15 lines, -0 lines	0 comments	Download
M	test/cctest/cctest.h	View	1 2 3	1 chunk	+20 lines, -0 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	1 2	18 chunks	+17 lines, -36 lines	0 comments	Download
M	test/cctest/test-weakmaps.cc	View	1 2 3 4	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/439233002/diff/1/test/mjsunit/regress/regress-399527.js File test/mjsunit/regress/regress-399527.js (right): https://codereview.chromium.org/439233002/diff/1/test/mjsunit/regress/regress-399527.js#newcode9 test/mjsunit/regress/regress-399527.js:9: for (var i = 0; i < 100000; ...

6 years, 4 months ago (2014-08-04 09:58:20 UTC) #3

Michael Starzinger

https://codereview.chromium.org/439233002/diff/20001/test/cctest/test-weakmaps.cc File test/cctest/test-weakmaps.cc (right): https://codereview.chromium.org/439233002/diff/20001/test/cctest/test-weakmaps.cc#newcode270 test/cctest/test-weakmaps.cc:270: if (marking->IsStopped()) { Please use SimulateIncrementalMarking instead of this ...

6 years, 4 months ago (2014-08-04 15:15:37 UTC) #4

Hannes Payer (out of office)

https://codereview.chromium.org/439233002/diff/20001/test/cctest/test-weakmaps.cc File test/cctest/test-weakmaps.cc (right): https://codereview.chromium.org/439233002/diff/20001/test/cctest/test-weakmaps.cc#newcode270 test/cctest/test-weakmaps.cc:270: if (marking->IsStopped()) { On 2014/08/04 15:15:37, Michael Starzinger wrote: ...

6 years, 4 months ago (2014-08-04 15:31:44 UTC) #5

Michael Starzinger

Still LGTM. https://codereview.chromium.org/439233002/diff/60001/test/cctest/test-weakmaps.cc File test/cctest/test-weakmaps.cc (right): https://codereview.chromium.org/439233002/diff/60001/test/cctest/test-weakmaps.cc#newcode268 test/cctest/test-weakmaps.cc:268: CHECK(*weak_map != NULL); nit: Can we just ...

6 years, 4 months ago (2014-08-04 15:35:30 UTC) #6

Hannes Payer (out of office)

https://codereview.chromium.org/439233002/diff/60001/test/cctest/test-weakmaps.cc File test/cctest/test-weakmaps.cc (right): https://codereview.chromium.org/439233002/diff/60001/test/cctest/test-weakmaps.cc#newcode268 test/cctest/test-weakmaps.cc:268: CHECK(*weak_map != NULL); On 2014/08/04 15:35:30, Michael Starzinger wrote: ...

6 years, 4 months ago (2014-08-04 16:09:35 UTC) #7

Hannes Payer (out of office)

6 years, 4 months ago (2014-08-05 07:29:22 UTC) #8

Message was sent while issue was closed.

Committed patchset #5 manually as 22844 (presubmit successful).

Expand Messages | Collapse Messages