Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 439223004: Add support for untagged LoadField, StoreField, LoadElement, and StoreElement simplfied operators. … (Closed)

Created:
6 years, 4 months ago by titzer
Modified:
6 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add support for untagged LoadField, StoreField, LoadElement, and StoreElement simplfied operators. This is needed for untagged accesses of typed array backing stores and generally cleans up. R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22815

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review comments. #

Total comments: 1

Patch Set 3 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -38 lines) Patch
M src/compiler/simplified-lowering.cc View 1 2 4 chunks +15 lines, -17 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 3 chunks +26 lines, -14 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 3 chunks +110 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
titzer
6 years, 4 months ago (2014-08-04 11:51:32 UTC) #1
Benedikt Meurer
https://codereview.chromium.org/439223004/diff/1/test/cctest/compiler/test-simplified-lowering.cc File test/cctest/compiler/test-simplified-lowering.cc (right): https://codereview.chromium.org/439223004/diff/1/test/cctest/compiler/test-simplified-lowering.cc#newcode89 test/cctest/compiler/test-simplified-lowering.cc:89: FieldAccess access = {true, JSObject::kMapOffset, Handle<Name>(), Type::Any(), Can we ...
6 years, 4 months ago (2014-08-04 11:53:57 UTC) #2
titzer
On 2014/08/04 11:53:57, Benedikt Meurer wrote: > https://codereview.chromium.org/439223004/diff/1/test/cctest/compiler/test-simplified-lowering.cc > File test/cctest/compiler/test-simplified-lowering.cc (right): > > https://codereview.chromium.org/439223004/diff/1/test/cctest/compiler/test-simplified-lowering.cc#newcode89 ...
6 years, 4 months ago (2014-08-04 12:10:55 UTC) #3
Benedikt Meurer
LGTM with nit. https://codereview.chromium.org/439223004/diff/20001/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/439223004/diff/20001/src/compiler/simplified-lowering.cc#newcode196 src/compiler/simplified-lowering.cc:196: bool base_is_tagged, MachineRepresentation representation, Type* type) ...
6 years, 4 months ago (2014-08-04 12:18:31 UTC) #4
titzer
On 2014/08/04 12:18:31, Benedikt Meurer wrote: > LGTM with nit. > > https://codereview.chromium.org/439223004/diff/20001/src/compiler/simplified-lowering.cc > File ...
6 years, 4 months ago (2014-08-04 12:25:44 UTC) #5
titzer
6 years, 4 months ago (2014-08-04 12:39:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as 22815 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698