Video Player: Fix minor error handling bugs

ui/file_manager/video_player/js/cast/cast_video_element.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Inverval for updating media info (in ms).
  * @type {number}
  * @const
@@ skipping 171 matching lines @@
 
   /**
    * Plays the video.
    */
   play: function() {
     var play = function() {
       this.castMedia_.play(null,
           function () {
             this.playInProgress_ = false;
           }.wrap(this),
-          function () {
+          function (error) {
             this.playInProgress_ = false;
-            this.onCastCommandError_();
+            this.onCastCommandError_(error);
           }.wrap(this));
     }.wrap(this);
 
     this.playInProgress_ = true;
 
     if (!this.castMedia_)
       this.load(play);
     else
       play();
   },
 
   /**
    * Pauses the video.
    */
   pause: function() {
     if (!this.castMedia_)
       return;
 
     this.pauseInProgress_ = true;
     this.castMedia_.pause(null,
         function () {
           this.pauseInProgress_ = false;
         }.wrap(this),
-        function () {
+        function (error) {
           this.pauseInProgress_ = false;
-          this.onCastCommandError_();
+          this.onCastCommandError_(error);
         }.wrap(this));
   },
 
   /**
    * Loads the video.
    */
   load: function(opt_callback) {
     var sendTokenPromise = this.mediaManager_.getToken().then(function(token) {
       this.token_ = token;
       this.sendMessage_({message: 'push-token', token: token});
@@ skipping 18 matching lines @@
 
           var request = new chrome.cast.media.LoadRequest(this.mediaInfo_);
           return new Promise(
               this.castSession_.loadMedia.bind(this.castSession_, request)).
               then(function(media) {
                 this.onMediaDiscovered_(media);
                 if (opt_callback)
                   opt_callback();
               }.bind(this));
         }.bind(this)).catch(function(error) {
+          this.unloadMedia_();
+          this.dispatchEvent(new Event('error'));
           console.error('Cast failed.', error.stack || error);
         });

[hirono, 2014/08/04 11:05:52]

.bind(this)?

[yoshiki, 2014/08/05 00:47:16]

Done.

   },
 
   /**
    * Unloads the video.
    * @private
    */
   unloadMedia_: function() {
     if (this.castMedia_) {
       this.castMedia_.stop(null,
           function () {},
-          function () {
+          function (error) {
             // Ignores session error, since session may already be closed.
             if (error.code !== chrome.cast.ErrorCode.SESSION_ERROR)
               this.onCastCommandError_(error);
           }.wrap(this));
 
       this.castMedia_.removeUpdateListener(this.onCastMediaUpdatedBound_);
       this.castMedia_ = null;
     }
     clearInterval(this.updateTimerId_);
   },
@@ skipping 65 matching lines @@
     // Notify that the metadata of the video is ready.
     this.dispatchEvent(new Event('loadedmetadata'));
 
     media.addUpdateListener(this.onCastMediaUpdatedBound_);
     this.updateTimerId_ = setInterval(this.onPeriodicalUpdateTimer_.bind(this),
                                       MEDIA_UPDATE_INTERVAL);
   },
 
   /**
    * This method should be called when a media command to cast is failed.
+   * @param {Object} error Object representing the error.
    * @private
    */
-  onCastCommandError_: function() {
+  onCastCommandError_: function(error) {
     this.unloadMedia_();
     this.dispatchEvent(new Event('error'));
+    console.error('Error on sending command to cast.', error.stack || error);
   },
 
   /**
    * This is called when any media data is updated and by the periodical timer
    * is fired.
    *
    * @param {boolean} alive Media availability. False if it's unavailable.
    * @private
    */
   onCastMediaUpdated_: function(alive) {
@@ skipping 31 matching lines @@
       this.dispatchEvent(new Event('durationchange'));
     }
 
     // Media is being unloaded.
     if (!alive) {
       this.unloadMedia_();
       return;
     }
   },
 };