Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 439223003: Video Player: Fix minor error handling bugs (Closed)

Created:
6 years, 4 months ago by yoshiki
Modified:
6 years, 4 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Video Player: Fix minor error handling bugs This patch fixes some minor issue on error handling: ignoring error and a bug on error handling. BUG=none TEST=none R=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287455

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed the comment #

Total comments: 2

Patch Set 3 : addressed the comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M ui/file_manager/video_player/js/cast/cast_video_element.js View 1 2 5 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
yoshiki
@hirono, PTAL. Thanks.
6 years, 4 months ago (2014-08-04 10:39:45 UTC) #1
hirono
https://codereview.chromium.org/439223003/diff/1/ui/file_manager/video_player/js/cast/cast_video_element.js File ui/file_manager/video_player/js/cast/cast_video_element.js (right): https://codereview.chromium.org/439223003/diff/1/ui/file_manager/video_player/js/cast/cast_video_element.js#newcode262 ui/file_manager/video_player/js/cast/cast_video_element.js:262: }); .bind(this)?
6 years, 4 months ago (2014-08-04 11:05:52 UTC) #2
yoshiki
@hirono, PTAL
6 years, 4 months ago (2014-08-05 00:32:36 UTC) #3
yoshiki
https://codereview.chromium.org/439223003/diff/1/ui/file_manager/video_player/js/cast/cast_video_element.js File ui/file_manager/video_player/js/cast/cast_video_element.js (right): https://codereview.chromium.org/439223003/diff/1/ui/file_manager/video_player/js/cast/cast_video_element.js#newcode262 ui/file_manager/video_player/js/cast/cast_video_element.js:262: }); On 2014/08/04 11:05:52, hirono wrote: > .bind(this)? Done.
6 years, 4 months ago (2014-08-05 00:47:16 UTC) #4
hirono
lgtm with a nit. https://codereview.chromium.org/439223003/diff/20001/ui/file_manager/video_player/js/cast/cast_video_element.js File ui/file_manager/video_player/js/cast/cast_video_element.js (right): https://codereview.chromium.org/439223003/diff/20001/ui/file_manager/video_player/js/cast/cast_video_element.js#newcode192 ui/file_manager/video_player/js/cast/cast_video_element.js:192: function (error) { nit: We ...
6 years, 4 months ago (2014-08-05 01:01:59 UTC) #5
yoshiki
https://codereview.chromium.org/439223003/diff/20001/ui/file_manager/video_player/js/cast/cast_video_element.js File ui/file_manager/video_player/js/cast/cast_video_element.js (right): https://codereview.chromium.org/439223003/diff/20001/ui/file_manager/video_player/js/cast/cast_video_element.js#newcode192 ui/file_manager/video_player/js/cast/cast_video_element.js:192: function (error) { On 2014/08/05 01:01:59, hirono wrote: > ...
6 years, 4 months ago (2014-08-05 01:40:24 UTC) #6
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 4 months ago (2014-08-05 01:40:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/439223003/40001
6 years, 4 months ago (2014-08-05 01:42:19 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 02:43:36 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 03:17:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/builds/3064)
6 years, 4 months ago (2014-08-05 03:17:16 UTC) #11
yoshiki
6 years, 4 months ago (2014-08-05 04:56:27 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 manually as 287455 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698