Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 439153005: Update webkit test for expected own properties (Closed)

Created:
6 years, 4 months ago by arv (Not doing code reviews)
Modified:
6 years, 4 months ago
Reviewers:
adamk, rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Update webkit test for expected own properties Follow up to: 438103002 BUG=None LOG=Y R=adamk@chromium.org, rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22949

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -42 lines) Patch
M test/webkit/fast/js/Object-getOwnPropertyNames.js View 1 chunk +21 lines, -21 lines 0 comments Download
M test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt View 1 chunk +21 lines, -21 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
arv (Not doing code reviews)
PTAL https://codereview.chromium.org/439153005/diff/1/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt File test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt (right): https://codereview.chromium.org/439153005/diff/1/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt#newcode80 test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt:80: FAIL getSortedOwnPropertyNames(RegExp) should be $&,$',$*,$+,$1,$2,$3,$4,$5,$6,$7,$8,$9,$_,$`,arguments,caller,input,lastMatch,lastParen,leftContext,length,multiline,name,prototype,rightContext. Was $&,$',$*,$+,$1,$2,$3,$4,$5,$6,$7,$8,$9,$_,$`,$input,arguments,caller,input,lastMatch,lastParen,leftContext,length,multiline,name,prototype,rightContext. I ...
6 years, 4 months ago (2014-08-04 19:57:18 UTC) #1
adamk
lgtm
6 years, 4 months ago (2014-08-04 20:57:35 UTC) #2
arv (Not doing code reviews)
On 2014/08/04 at 20:57:35, adamk wrote: > lgtm Thanks. Can you land this for me?
6 years, 4 months ago (2014-08-04 21:02:04 UTC) #3
adamk
I am not in OWNERS, so we should probably get someone else to review...
6 years, 4 months ago (2014-08-04 21:39:53 UTC) #4
rossberg
lgtm
6 years, 4 months ago (2014-08-05 12:58:07 UTC) #5
adamk
6 years, 4 months ago (2014-08-06 19:30:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as 22949 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698