Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: third_party/yasm/yasm.gyp

Issue 439113002: Convert another clang warning that I missed in r287137. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/yasm/yasm.gyp
diff --git a/third_party/yasm/yasm.gyp b/third_party/yasm/yasm.gyp
index b691d8601778a7e6534c54f3b644822e7b1476c7..78f196676670c052b007b7608c3adfcee0e978a0 100644
--- a/third_party/yasm/yasm.gyp
+++ b/third_party/yasm/yasm.gyp
@@ -534,19 +534,10 @@
'cflags': [
'-std=gnu99',
],
- 'conditions': [
- ['clang==1', {
- 'xcode_settings': {
- 'WARNING_CFLAGS': [
- # re2c is missing CLOSEVOP from one switch.
- '-Wno-switch',
- ],
- },
- 'cflags': [
- '-Wno-switch',
- ],
- }],
- ],
+ 'variables': {
+ # re2c is missing CLOSEVOP from one switch.
+ 'clang_warning_flags': [ '-Wno-switch' ],
+ },
'msvs_disabled_warnings': [ 4267 ],
},
{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698