Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 439073002: Web Notifications should always reappear as popups when updated. (Closed)

Created:
6 years, 4 months ago by Peter Beverloo
Modified:
6 years, 4 months ago
Reviewers:
dewittj
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Web Notifications should always reappear as popups when updated. The message center already does this for notifications with a higher priority than the notification they replace, but this makes it explicit for Web Notifications (which cannot indicate priority). TBR=dewittj (reviewed in cl 301713002) BUG=366102 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287682

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -2 lines) Patch
M chrome/browser/notifications/notification_browsertest.cc View 1 3 chunks +37 lines, -0 lines 0 comments Download
M ui/message_center/notification_list.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/message_center/notification_list_unittest.cc View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Peter Beverloo
Same as 301713002, but without enabling the test which does leak memory. I'll fix that ...
6 years, 4 months ago (2014-08-02 15:45:33 UTC) #1
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 4 months ago (2014-08-02 15:45:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/439073002/1
6 years, 4 months ago (2014-08-02 15:46:26 UTC) #3
Peter Beverloo
The CQ bit was unchecked by peter@chromium.org
6 years, 4 months ago (2014-08-02 16:01:03 UTC) #4
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 4 months ago (2014-08-05 20:00:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/439073002/20001
6 years, 4 months ago (2014-08-05 20:01:36 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-06 00:11:02 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 05:37:01 UTC) #8
Message was sent while issue was closed.
Change committed as 287682

Powered by Google App Engine
This is Rietveld 408576698