Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: LayoutTests/css3/flexbox/flexbox-height-with-overflow-auto.html

Issue 439063002: flexbox: incorrect flexbox height with overflow:auto on flex item (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/css3/flexbox/flexbox-height-with-overflow-auto.html
diff --git a/LayoutTests/css3/flexbox/flexbox-height-with-overflow-auto.html b/LayoutTests/css3/flexbox/flexbox-height-with-overflow-auto.html
new file mode 100644
index 0000000000000000000000000000000000000000..175368cf8bfca35c57cad4fcefea71d78c0432fd
--- /dev/null
+++ b/LayoutTests/css3/flexbox/flexbox-height-with-overflow-auto.html
@@ -0,0 +1,92 @@
+<!DOCTYPE html>
+<html>
+<link href="resources/flexbox.css" rel="stylesheet">
+<style>
+.flexbox {
+ border:5px solid green;
cbiesinger 2014/08/08 03:47:29 nit: please consistently add a space after the col
harpreet.sk 2014/08/08 05:35:04 Done.
+ position:relative;
+ width:50px;
+}
+
+.inline-flexbox {
+ border:5px solid green;
+ position:relative;
+ height:50px;
+}
+
+.overflow {
+ border:1px solid red;
+ overflow:auto;
+}
+
+.vertical {
+ -webkit-writing-mode: vertical-rl;
+}
+</style>
+<script src="../../resources/check-layout.js"></script>
+<body onload="checkLayout('.flexbox'); checkLayout('.inline-flexbox')">
+<div class="flexbox" data-expected-height="47">
cbiesinger 2014/08/08 03:47:29 I must be missing something. I don't understand wh
cbiesinger 2014/08/08 03:56:39 I must've done something wrong in my test. it's 47
+ <div class="overflow"><div style="width:100px; height:20px"></div></div>
cbiesinger 2014/08/08 03:47:29 also in these attributes
harpreet.sk 2014/08/08 05:35:04 Done.
+</div>
+
+<div class="flexbox row-reverse" data-expected-height="47">
+ <div class="overflow"><div style="width:100px; height:20px"></div></div>
+</div>
+
+<div class="flexbox vertical" data-expected-height="32">
+ <div class="overflow"><div style="width:100px; height:20px"></div></div>
+</div>
+
+<div class="flexbox row-reverse vertical" data-expected-height="32">
+ <div class="overflow"><div style="width:100px; height:20px"></div></div>
+</div>
+
+<div class="flexbox" data-expected-height="47">
+ <div class="overflow align-self-baseline"><div style="width:100px; height:20px"></div></div>
+</div>
+
+<div class="flexbox row-reverse" data-expected-height="47">
+ <div class="overflow align-self-baseline"><div style="width:100px; height:20px"></div></div>
+</div>
+
+<div class="flexbox vertical" data-expected-height="32">
+ <div class="overflow align-self-baseline"><div style="width:100px; height:20px"></div></div>
+</div>
+
+<div class="flexbox row-reverse vertical" data-expected-height="32">
+ <div class="overflow align-self-baseline"><div style="width:100px; height:20px"></div></div>
+</div>
+
+<div class="inline-flexbox column" data-expected-width="32">
+ <div class="overflow"><div style="width:20px; height:100px"></div></div>
+</div>
+
+<div class="inline-flexbox column-reverse" data-expected-width="32">
+ <div class="overflow"><div style="width:20px; height:100px"></div></div>
+</div>
+
+<div class="inline-flexbox column vertical" data-expected-width="47">
+ <div class="overflow"><div style="width:20px; height:100px"></div></div>
+</div>
+
+<div class="inline-flexbox column-reverse vertical" data-expected-width="47">
+ <div class="overflow"><div style="width:20px; height:100px"></div></div>
+</div>
+
+<div class="inline-flexbox column" data-expected-width="32">
+ <div class="overflow align-self-baseline"><div style="width:20px; height:100px"></div></div>
+</div>
+
+<div class="inline-flexbox column-reverse" data-expected-width="32">
+ <div class="overflow align-self-baseline"><div style="width:20px; height:100px"></div></div>
+</div>
+
+<div class="inline-flexbox column vertical" data-expected-width="32">
+ <div class="overflow align-self-baseline"><div style="width:20px; height:100px"></div></div>
+</div>
+
+<div class="inline-flexbox column-reverse vertical" data-expected-width="32">
+ <div class="overflow align-self-baseline"><div style="width:20px; height:100px"></div></div>
+</div>
+</body>
+</html>

Powered by Google App Engine
This is Rietveld 408576698