Source/core/rendering/RenderFlexibleBox.h - Issue 439063002: flexbox: incorrect flexbox height with overflow:auto on flex item

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderFlexibleBox.h

Issue 439063002: flexbox: incorrect flexbox height with overflow:auto on flex item (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressing the nit Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/css3/flexbox/flexbox-height-with-overflow-auto-expected.txt ('k') | Source/core/rendering/RenderFlexibleBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderFlexibleBox.h

diff --git a/Source/core/rendering/RenderFlexibleBox.h b/Source/core/rendering/RenderFlexibleBox.h

index cfec2ad4310abbbefa70f90e63354bf05e8d9bb2..342a6a73e6ea28e6d3b87b84b26ea93fcc1eb2cb 100644

--- a/Source/core/rendering/RenderFlexibleBox.h

+++ b/Source/core/rendering/RenderFlexibleBox.h

@@ -112,6 +112,7 @@ private:

LayoutUnit flowAwareMarginBeforeForChild(RenderBox* child) const;

LayoutUnit crossAxisMarginExtentForChild(RenderBox* child) const;

LayoutUnit crossAxisScrollbarExtent() const;

+ LayoutUnit crossAxisScrollbarExtentForChild(RenderBox* child) const;

LayoutPoint flowAwareLocationForChild(RenderBox* child) const;

// FIXME: Supporting layout deltas.

void setFlowAwareLocationForChild(RenderBox* child, const LayoutPoint&);