Move ImageLoaderTest to extensions_unittests

Move ImageLoaderTest to extensions_unittests

* Give it its own copy of its test data, instead of sharing with other
unrelated tests that live in src/chrome.
* Introduce ChromeComponentExtensionResourceManagerTest to address a TODO
and eliminate the src/chrome dependency.

BUG=397164
TEST=unit_tests, extensions_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287885

[James Cook, 2014-08-02 01:33:00]

mukai, PTAL at chrome_component_extension_resource_manager_unittest.cc

yoz, PTAL at the rest

[Jun Mukai, 2014-08-02 01:41:49]

lgtm!!

[James Cook, 2014-08-02 03:49:05]

On 2014/08/02 01:41:49, Jun Mukai wrote:
> lgtm!!

I may need to land the new test data separately because it contains binary data.
The failures look like the try jobs are failing to load the images, but things
pass locally.  I'll look on Monday.

[Yoyo Zhou, 2014-08-04 21:15:01]

LGTM, but why do we need the 16 and 24 icons in the test data? Shouldn't it only
need the component extension resource?

https://chromiumcodereview.appspot.com/439023002/diff/20001/chrome/browser/ex...
File
chrome/browser/extensions/chrome_component_extension_resource_manager_unittest.cc
(right):

https://chromiumcodereview.appspot.com/439023002/diff/20001/chrome/browser/ex...
chrome/browser/extensions/chrome_component_extension_resource_manager_unittest.cc:42:
test_path, FILE_PATH_LITERAL("app.json"), &error));
If this isn't called manifest.json, I will wonder "is something special going
on?" As it turns out, no. So I would just call it manifest.json.

[James Cook, 2014-08-04 21:24:47]

I needed to copy the test data so that the test in src/extensions would not have
a dependency on src/chrome via src/chrome/test/data/extensions/...

Is there another way to do it that I'm not seeing?

https://chromiumcodereview.appspot.com/439023002/diff/20001/chrome/browser/ex...
File
chrome/browser/extensions/chrome_component_extension_resource_manager_unittest.cc
(right):

https://chromiumcodereview.appspot.com/439023002/diff/20001/chrome/browser/ex...
chrome/browser/extensions/chrome_component_extension_resource_manager_unittest.cc:42:
test_path, FILE_PATH_LITERAL("app.json"), &error));
On 2014/08/04 21:15:01, Yoyo Zhou wrote:
> If this isn't called manifest.json, I will wonder "is something special going
> on?" As it turns out, no. So I would just call it manifest.json.

OK. This is existing test data in chrome/test/data/extensions. I will rename the
file.

[Yoyo Zhou, 2014-08-04 21:30:13]

Ah, sorry. I was only looking at the new test and missed that the old ones also
use the same data directory.

[James Cook, 2014-08-05 16:58:35]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-08-05 17:00:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamescook@chromium.org/439023002/60001

[commit-bot: I haz the power, 2014-08-05 21:25:57]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/42720)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-05 21:56:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-05 21:56:29]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2014-08-06 18:33:24]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-08-06 18:37:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamescook@chromium.org/439023002/100001

[commit-bot: I haz the power, 2014-08-06 22:59:50]

Change committed as 287885