Apply test isolation goodness to net_unittests.

Apply test isolation goodness to net_unittests.

We're going to have it enabled for all tests, but I'm enabling
it one-by-one to limit damage from possible problems.

TEST=none
BUG=12710
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33202

[Paweł Hajdan Jr., 2009-11-23 20:45:13]

Hope you'll like it. The short story is that this makes it harder to
accidentally carry state from one test to another (for example via Singletons).

[eroman, 2009-11-23 21:15:42]

LGTM

however, the try job had some failures, make sure it passes before committing.

[wtc, 2009-11-24 19:12:31]

LGTM.

[Paweł Hajdan Jr., 2009-11-25 11:59:52]

On 2009/11/23 21:15:42, eroman wrote:
> LGTM
> 
> however, the try job had some failures, make sure it passes before committing.

Indeed, failures in Linux-specific code. I fixed it to tear down properly.
Please review the updates.

[wtc, 2009-11-25 18:17:01]

LGTM.

http://codereview.chromium.org/439007/diff/2001/3001
File net/base/host_resolver_proc.cc (right):

http://codereview.chromium.org/439007/diff/2001/3001#newcode109
net/base/host_resolver_proc.cc:109: friend struct
DefaultSingletonTraits<DnsReloadTimer>;
Do singleton classes need to have their constructor and
destructor declared private?

[Paweł Hajdan Jr., 2009-11-25 21:22:15]

On 2009/11/25 18:17:01, wtc wrote:
> LGTM.
> 
> http://codereview.chromium.org/439007/diff/2001/3001
> File net/base/host_resolver_proc.cc (right):
> 
> http://codereview.chromium.org/439007/diff/2001/3001#newcode109
> net/base/host_resolver_proc.cc:109: friend struct
> DefaultSingletonTraits<DnsReloadTimer>;
> Do singleton classes need to have their constructor and
> destructor declared private?

Not strictly needed, but helps prevent misuse (making other instances for
example).