Issue 438963008: Add test case for item not being displayed at each page break when it should be.

Issue 438963008: Add test case for item not being displayed at each page break when it should be. (Closed)

Created:
6 years, 4 months ago by ivandavid

Modified:
6 years, 4 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, Dan Beam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add test case for item not being displayed at each page break when it should be. The test case is a modification of the test html in the bug. The image was replaced and the code was reformatted because it was poorly spaced. The new test case still shows the same behavior. BUG=326834 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287875

Patch Set 1 #

Patch Set 2 : Added expected PNG. #

Total comments: 1

Patch Set 3 : Uploaded win expected output and compressed the image with pngcrush. #

Patch Set 4 : Uploading correct PNG. #

Patch Set 5 : Added a test expectation. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -1 line)			Patch
M	chrome/test/data/printing/layout_tests/TestExpectations	View	1 2 3 4	1 chunk	+5 lines, -1 line	0 comments	Download
A	chrome/test/data/printing/layout_tests/platform/win/source_html/css/repeating-item-expected.png	View	1 2 3	Binary file		0 comments	Download
A	chrome/test/data/printing/layout_tests/source_html/css/repeating-item.html	View	1 2	1 chunk	+45 lines, -0 lines	0 comments	Download
A	chrome/test/data/printing/layout_tests/source_html/css/resources/logo.png	View	1 2 3	Binary file		0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

ivandavid

This is a print preview bug, so I took the test case in the bug ...

6 years, 4 months ago (2014-08-02 04:14:25 UTC) #1

ivandavid

On 2014/08/02 04:14:25, ivandavid wrote: > This is a print preview bug, so I took ...

6 years, 4 months ago (2014-08-02 04:14:58 UTC) #2

Lei Zhang

- You probably want a common resources folder, rather than one for each test type? ...

6 years, 4 months ago (2014-08-04 19:28:43 UTC) #3

ivandavid

On 2014/08/04 19:28:43, Lei Zhang wrote: > - You probably want a common resources folder, ...

6 years, 4 months ago (2014-08-04 20:56:02 UTC) #4

Lei Zhang

On 2014/08/04 20:56:02, ivandavid wrote: > Also, what other programs can I use for compressing ...

6 years, 4 months ago (2014-08-04 21:29:30 UTC) #5

ivandavid

I added the crushed PNG. I will update TestExpectations after the other expected files getting ...

6 years, 4 months ago (2014-08-06 01:16:35 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivandavid@chromium.org/438963008/80001

6 years, 4 months ago (2014-08-06 22:22:39 UTC) #11

Message was sent while issue was closed.

Change committed as 287875

Expand Messages | Collapse Messages