Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: hunspell.gyp

Issue 438963006: Update clang warnings after r287092. (Closed) Base URL: http://src.chromium.org/chrome/trunk/deps/third_party/hunspell/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: hunspell.gyp
===================================================================
--- hunspell.gyp (revision 283809)
+++ hunspell.gyp (working copy)
@@ -63,6 +63,15 @@
'USE_HUNSPELL',
],
},
+ 'variables': {
+ 'clang_warning_flags': [
+ # affentry.cxx has one `while ((p = nextchar(p)));` parsing loop.
+ '-Wno-empty-body',
+ # affentry.hxx has NULL as default parameter for a FLAG in two
+ # places.
+ '-Wno-null-conversion',
+ ],
+ },
# TODO(jschuh): http://crbug.com/167187 size_t -> int
'msvs_disabled_warnings': [ 4267 ],
'conditions': [
@@ -80,21 +89,6 @@
'-Wno-conversion-null',
],
}],
- ['clang == 1', {
- 'xcode_settings': {
- 'WARNING_CFLAGS': [
- # affentry.cxx has one `while ((p = nextchar(p)));` parsing loop.
- '-Wno-empty-body',
- # affentry.hxx has NULL as default parameter for a FLAG in two
- # places.
- '-Wno-null-conversion',
- ],
- },
- 'cflags': [
- '-Wno-empty-body',
- '-Wno-null-conversion',
- ],
- }],
],
},
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698