Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1666)

Issue 438963005: Purge net/ and ui/base from media_unittest DEPS. (Closed)

Created:
6 years, 4 months ago by DaleCurtis
Modified:
6 years, 4 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Purge net/ and ui/base from media_unittest DEPS. Saves us over 1200 files during compilation!! Also cleans up media_perftests for a smaller savings. BUG=302505 TEST=media_unittests is at ~3000 files now. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287189

Patch Set 1 #

Patch Set 2 : Fix all the browsertests! #

Patch Set 3 : Remove gl from perftests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -30 lines) Patch
M chrome/browser/media/encrypted_media_istypesupported_browsertest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/media/media_browsertest.cc View 2 chunks +7 lines, -1 line 0 comments Download
M content/browser/media/media_browsertest.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M media/BUILD.gn View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M media/DEPS View 1 chunk +1 line, -2 lines 0 comments Download
M media/base/test_data_util.h View 2 chunks +0 lines, -4 lines 0 comments Download
M media/base/test_data_util.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M media/media.gyp View 1 2 4 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
DaleCurtis
Bots on PS#2 look good, though there was a ui/gl extra which can be pared ...
6 years, 4 months ago (2014-08-01 23:32:56 UTC) #1
rileya (GONE FROM CHROMIUM)
On 2014/08/01 23:32:56, DaleCurtis wrote: > Bots on PS#2 look good, though there was a ...
6 years, 4 months ago (2014-08-01 23:56:53 UTC) #2
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 4 months ago (2014-08-01 23:58:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/438963005/10008
6 years, 4 months ago (2014-08-02 00:00:22 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 08:07:46 UTC) #5
Message was sent while issue was closed.
Change committed as 287189

Powered by Google App Engine
This is Rietveld 408576698