Docserver: Add annotation to intro_tables.json to restrict content by platform

Docserver: Add annotation to intro_tables.json to restrict content by platform

BUG=233971
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287101

[ahernandez, 2014-08-01 19:06:25]

Uploading this patch to fix the issue with Learn More linking to content for the
wrong platform. It seems like an easy/minimal change, hopefully it's a desirable
solution.

[not at google - send to devlin, 2014-08-01 19:23:44]

https://codereview.chromium.org/438963003/diff/1/chrome/common/extensions/doc...
File chrome/common/extensions/docs/templates/json/intro_tables.json (right):

https://codereview.chromium.org/438963003/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/templates/json/intro_tables.json:218:
"restrictedTo": "apps"
"restrictedTo" is a bit vague, maybe re-use the "extension_types" key, like

"extension_types": ["platform_app"], seems to be what other places use:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...

(as well as the feature files of course)

[ahernandez, 2014-08-01 19:28:23]

https://codereview.chromium.org/438963003/diff/1/chrome/common/extensions/doc...
File chrome/common/extensions/docs/templates/json/intro_tables.json (right):

https://codereview.chromium.org/438963003/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/templates/json/intro_tables.json:218:
"restrictedTo": "apps"
On 2014/08/01 19:23:44, kalman wrote:
> "restrictedTo" is a bit vague, maybe re-use the "extension_types" key, like
> 
> "extension_types": ["platform_app"], seems to be what other places use:
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...
> 
> (as well as the feature files of course)

Should I add the annotation to every link then?

[not at google - send to devlin, 2014-08-01 19:29:20]

https://codereview.chromium.org/438963003/diff/1/chrome/common/extensions/doc...
File chrome/common/extensions/docs/templates/json/intro_tables.json (right):

https://codereview.chromium.org/438963003/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/templates/json/intro_tables.json:218:
"restrictedTo": "apps"
On 2014/08/01 19:28:22, ahernandez wrote:
> On 2014/08/01 19:23:44, kalman wrote:
> > "restrictedTo" is a bit vague, maybe re-use the "extension_types" key, like
> > 
> > "extension_types": ["platform_app"], seems to be what other places use:
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...
> > 
> > (as well as the feature files of course)
> 
> Should I add the annotation to every link then?

nah just default to everything. just modify this line.

[ahernandez, 2014-08-01 19:44:11]

PTAL.

[not at google - send to devlin, 2014-08-01 19:59:53]

lgtm

https://codereview.chromium.org/438963003/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/server2/jsc_view.py (right):

https://codereview.chromium.org/438963003/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/server2/jsc_view.py:550: if ext_type not in
node.get('extension_types', [ext_type]):
nit: use (ext_type,) not [ext_type]

[ahernandez, 2014-08-01 21:15:56]

The CQ bit was checked by ahernandez.miralles@gmail.com

[commit-bot: I haz the power, 2014-08-01 21:17:21]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/ahernandez.miralles@gmail.com/43896300...

[commit-bot: I haz the power, 2014-08-01 22:02:13]

Change committed as 287101