chrome/browser/ui/cocoa/passwords/OWNERS - Issue 438893002: Add ManagePasswordItemViewController and unit tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/passwords/OWNERS

Issue 438893002: Add ManagePasswordItemViewController and unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add another test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 dconnelly@chromium.org
	Scott Hess - ex-Googler 2014/08/06 17:56:38 Is this intended to cause people to loop you in fo Is this intended to cause people to loop you in for reviews? AFAICT you really haven't made many CLs under chrome/browser/ui/cocoa, so I'm not entirely sure it's appropriate. But I don't know for sure what our metrics are for evaluating things. dconnelly 2014/08/07 13:10:04 Yes. Was duplicating the views/ side, where our te Show quoted text On 2014/08/06 17:56:38, Scott Hess wrote: > Is this intended to cause people to loop you in for reviews? Yes. Was duplicating the views/ side, where our team (Privacy) members who wrote the views/ side own chrome/browser/ui/views/passwords. Show quoted text > AFAICT you really > haven't made many CLs under chrome/browser/ui/cocoa, so I'm not entirely sure > it's appropriate. But I don't know for sure what our metrics are for evaluating > things. No problem. Removed.
OLD	NEW