Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 438843002: Delete code for inspector preferences. (Closed)

Created:
6 years, 4 months ago by chrishtr
Modified:
6 years, 4 months ago
Reviewers:
jam, boliu, dcheng
CC:
android-webview-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Delete code for inspector preferences. It's not used anywhere. BUG=399506 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291266

Patch Set 1 #

Patch Set 2 : Merged. #

Patch Set 3 : Fix #

Patch Set 4 : Merged. #

Patch Set 5 : Merged. #

Total comments: 2

Patch Set 6 : Fixed. #

Patch Set 7 : Fix build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -95 lines) Patch
M android_webview/browser/aw_content_browser_client.h View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 2 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 2 3 4 5 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 3 4 5 6 2 chunks +0 lines, -8 lines 0 comments Download
M content/common/view_messages.h View 1 2 3 4 5 6 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/web_preferences.h View 1 2 3 4 5 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 6 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
chrishtr
See also crrev.com/436813002.
6 years, 4 months ago (2014-08-01 05:06:41 UTC) #1
chrishtr
Darin, sending to you since John is busy with code yellow.
6 years, 4 months ago (2014-08-04 16:29:01 UTC) #2
chrishtr
6 years, 4 months ago (2014-08-06 02:53:20 UTC) #3
boliu
android_webview lgtm
6 years, 4 months ago (2014-08-06 02:57:42 UTC) #4
chrishtr
6 years, 4 months ago (2014-08-08 19:22:37 UTC) #5
jam
lgtm with comment, thanks for the cleanup https://codereview.chromium.org/438843002/diff/80001/content/public/common/web_preferences.h File content/public/common/web_preferences.h (right): https://codereview.chromium.org/438843002/diff/80001/content/public/common/web_preferences.h#newcode28 content/public/common/web_preferences.h:28: // WebInspectorPreferences; ...
6 years, 4 months ago (2014-08-19 19:48:11 UTC) #6
chrishtr
https://codereview.chromium.org/438843002/diff/80001/content/public/common/web_preferences.h File content/public/common/web_preferences.h (right): https://codereview.chromium.org/438843002/diff/80001/content/public/common/web_preferences.h#newcode28 content/public/common/web_preferences.h:28: // WebInspectorPreferences; On 2014/08/19 19:48:11, jam wrote: > nit: ...
6 years, 4 months ago (2014-08-19 21:27:26 UTC) #7
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 4 months ago (2014-08-20 17:44:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/438843002/120001
6 years, 4 months ago (2014-08-20 17:44:39 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-20 19:03:57 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 19:09:37 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/5549)
6 years, 4 months ago (2014-08-20 19:09:38 UTC) #12
chrishtr
+cevans for view_messages.h and common_param_traits_macros.h.
6 years, 4 months ago (2014-08-20 20:29:57 UTC) #13
chrishtr
Ping? The approval here is very simple.
6 years, 4 months ago (2014-08-21 21:31:04 UTC) #14
chrishtr
6 years, 4 months ago (2014-08-21 23:59:10 UTC) #15
chrishtr
Ok changed to dcheng@.
6 years, 4 months ago (2014-08-21 23:59:31 UTC) #16
dcheng
rslgtm for deletion-only changes of view_messages.h and common_param_traits_macros.h
6 years, 4 months ago (2014-08-22 00:11:03 UTC) #17
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 4 months ago (2014-08-22 00:15:21 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/438843002/120001
6 years, 4 months ago (2014-08-22 00:20:42 UTC) #19
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 00:28:48 UTC) #20
Message was sent while issue was closed. 
Committed patchset #7 (120001) as 291266

Powered by Google App Engine
This is Rietveld 408576698