Issue 438783002: Ensure that SkDebugf is exported from the library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 438783002: Ensure that SkDebugf is exported from the library. (Closed)

Created:
6 years, 4 months ago by gw280

Modified:
6 years, 4 months ago

Reviewers:
bsalomon, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Ensure that SkDebugf is exported from the library. This was caused by the change to always call SkDebugf() in SkASSERT(). There are many headers in Skia that call SkASSERT and so we were seeing linking issues in Gecko where we were using Skia across DLL boundaries. R=reed1 BUG=skia: Committed: https://skia.googlesource.com/skia/+/c4ade57cd4ce5083e0fac19111a6ee6e32e18df4

Patch Set 1 #

Patch Set 2 : Move SK_API to the beginning of the line #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	include/core/SkTypes.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/george@mozilla.com/438783002/20001

6 years, 4 months ago (2014-08-01 18:49:34 UTC) #3

commit-bot: I haz the power

6 years, 4 months ago (2014-08-01 19:02:13 UTC) #4

Message was sent while issue was closed.

Change committed as c4ade57cd4ce5083e0fac19111a6ee6e32e18df4

Expand Messages | Collapse Messages