Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 438733002: Revert https://src.chromium.org/viewvc/chrome?view=rev&revision=283728 (Closed)

Created:
6 years, 4 months ago by Tom Sepez
Modified:
6 years, 4 months ago
Reviewers:
Charlie Reis, sky
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, miu+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert https://src.chromium.org/viewvc/chrome?view=rev&revision=283728 As of https://src.chromium.org/viewvc/blink?view=rev&revision=179240, Blink no longer implements the behaviour that corresponds to this change. Everything is handled blink-side, so remove this support. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -69 lines) Patch
M chrome/browser/ui/browser_commands.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 3 chunks +0 lines, -11 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/browser/navigation_entry.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Tom Sepez
Creis, Sky, please review. The hood news is there's a better way to do this ...
6 years, 4 months ago (2014-07-31 20:32:09 UTC) #1
sky
LGTM
6 years, 4 months ago (2014-07-31 21:15:11 UTC) #2
Charlie Reis
Huzzah! LGTM. (Sorry for the delay; I was out on vacation the last few days.)
6 years, 4 months ago (2014-08-05 17:11:11 UTC) #3
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 4 months ago (2014-08-05 17:35:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/438733002/1
6 years, 4 months ago (2014-08-05 17:36:37 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-05 20:47:00 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 22:11:18 UTC) #7
Message was sent while issue was closed.
Change committed as 287611

Powered by Google App Engine
This is Rietveld 408576698