Relayout RenderObjects with viewport-percentage CSS properties when viewport size changes

Source/core/rendering/RenderView.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 301 matching lines @@
     bool relayoutChildren = !shouldUsePrintingLayout() && (!m_frameView || width() != viewWidth() || height() != viewHeight());
     if (relayoutChildren) {
         layoutScope.setChildNeedsLayout(this);
         for (RenderObject* child = firstChild(); child; child = child->nextSibling()) {
             if (child->isSVGRoot())
                 continue;
 
             if ((child->isBox() && toRenderBox(child)->hasRelativeLogicalHeight())
                     || child->style()->logicalHeight().isPercent()
                     || child->style()->logicalMinHeight().isPercent()
-                    || child->style()->logicalMaxHeight().isPercent()
-                    || child->style()->logicalHeight().isViewportPercentage()
-                    || child->style()->logicalMinHeight().isViewportPercentage()
-                    || child->style()->logicalMaxHeight().isViewportPercentage())
+                    || child->style()->logicalMaxHeight().isPercent())
                 layoutScope.setChildNeedsLayout(child);
         }
 
+        if (m_viewportPercentageStyleObjects) {
+            ViewportPercentageStyleObjectSet::const_iterator end = m_viewportPercentageStyleObjects->end();
+            for (ViewportPercentageStyleObjectSet::const_iterator it = m_viewportPercentageStyleObjects->begin(); it != end; ++it)
+                layoutScope.setChildNeedsLayout(*it);
+        }
+
         if (document().svgExtensions())
             document().accessSVGExtensions()->invalidateSVGRootsWithRelativeLengthDescendents(&layoutScope);
     }
 
     ASSERT(!m_layoutState);
     if (!needsLayout())
         return;
 
     LayoutState state;
     bool isSeamlessAncestorInFlowThread = initializeLayoutState(state);
@@ skipping 890 matching lines @@
     return std::min(viewLogicalWidth(ScrollableArea::IncludeScrollbars), viewLogicalHeight(ScrollableArea::IncludeScrollbars))
         * percentage / 100.f;
 }
 
 LayoutUnit RenderView::viewportPercentageMax(float percentage) const
 {
     return std::max(viewLogicalWidth(ScrollableArea::IncludeScrollbars), viewLogicalHeight(ScrollableArea::IncludeScrollbars))
         * percentage / 100.f;
 }
 
+void RenderView::addViewportPercentageStyleObject(RenderObject* object)
+{
+    if (!m_viewportPercentageStyleObjects)
+        m_viewportPercentageStyleObjects = adoptPtr(new ViewportPercentageStyleObjectSet);
+
+    m_viewportPercentageStyleObjects->add(object);

[leviw_travelin_and_unemployed, 2013/10/25 20:30:35]

Can you add asserts that we aren't double-adding or double-removing objects?

+}
+
+void RenderView::removeViewportPercentageStyleObject(RenderObject* object)
+{
+    if (m_viewportPercentageStyleObjects)
+        m_viewportPercentageStyleObjects->remove(object);
+}
+
 FragmentationDisabler::FragmentationDisabler(RenderObject* root)
 {
     RenderView* renderView = root->view();
     ASSERT(renderView);
 
     LayoutState* layoutState = renderView->layoutState();
 
     m_root = root;
     m_fragmenting = layoutState && layoutState->isPaginated();
     m_flowThreadState = m_root->flowThreadState();
@@ skipping 19 matching lines @@
 #endif
 
     if (layoutState)
         layoutState->m_isPaginated = m_fragmenting;
 
     if (m_flowThreadState != RenderObject::NotInsideFlowThread)
         m_root->setFlowThreadStateIncludingDescendants(m_flowThreadState);
 }
 
 } // namespace WebCore