Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 438723003: Revert of Listen for key events in SetupXI2ForXWindow() (Closed)

Created:
6 years, 4 months ago by erikchen
Modified:
6 years, 4 months ago
CC:
chromium-reviews, tdresser+watch_chromium.org, flackr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Listen for key events in SetupXI2ForXWindow() (https://codereview.chromium.org/404423002/) Reason for revert: linux asan error: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/5919/steps/interactive_ui_tests/logs/GlobalCommand Original issue's description: > Listen for key events in SetupXI2ForXWindow() > > BUG=368750 > R=sadrul > TEST=on device and desktop > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286866 TBR=sadrul@chromium.org,erg@chromium.org,kpschoedel@chromium.org NOTREECHECKS=true NOTRY=true BUG=368750 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -19 lines) Patch
M chrome/browser/ui/libgtk2ui/x11_input_method_context_impl_gtk2.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M ui/events/x/touch_factory_x11.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
erikchen
Created Revert of Listen for key events in SetupXI2ForXWindow()
6 years, 4 months ago (2014-07-31 20:46:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/438723003/1
6 years, 4 months ago (2014-07-31 20:47:35 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 20:50:00 UTC) #3
Message was sent while issue was closed.
Change committed as 286888

Powered by Google App Engine
This is Rietveld 408576698