Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 438683002: nanobench: support GMs-as-benches (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org, bsalomon
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

nanobench: support GMs-as-benches BUG=skia: Committed: https://skia.googlesource.com/skia/+/e714e75c725c987fe682a1f5473224fe3e80380d

Patch Set 1 #

Patch Set 2 : GM_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -9 lines) Patch
M bench/GMBench.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M bench/nanobench.cpp View 8 chunks +36 lines, -6 lines 0 comments Download
M gyp/bench.gyp View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
6 years, 4 months ago (2014-07-31 18:43:11 UTC) #1
mtklein
This produces JSON like this: { "gitHash":"unknown-revision", "options":{ "system":"UNIX" }, "results":{ "GM:circular-clips_800_600":{ "565":{ "max_ms":4.385410, "mean_ms":4.385410, ...
6 years, 4 months ago (2014-07-31 18:44:26 UTC) #2
jcgregorio
On 2014/07/31 18:44:26, mtklein wrote: > This produces JSON like this: > > { > ...
6 years, 4 months ago (2014-07-31 18:49:43 UTC) #3
mtklein
> Can you use GM_ instead of GM:? It would work much better with the ...
6 years, 4 months ago (2014-07-31 18:56:12 UTC) #4
jcgregorio
On 2014/07/31 18:56:12, mtklein wrote: > > Can you use GM_ instead of GM:? It ...
6 years, 4 months ago (2014-07-31 18:56:57 UTC) #5
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-07-31 19:01:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/438683002/20001
6 years, 4 months ago (2014-07-31 19:02:36 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 19:13:52 UTC) #8
Message was sent while issue was closed.
Change committed as e714e75c725c987fe682a1f5473224fe3e80380d

Powered by Google App Engine
This is Rietveld 408576698