Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 438673003: Add CFPropertyToLaunchData() and its test (Closed)

Created:
6 years, 4 months ago by Mark Mentovai
Modified:
6 years, 4 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add CFPropertyToLaunchData() and its test. TEST=util_test Launchd R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/293964f69b8b

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+511 lines, -0 lines) Patch
A util/mac/launchd.h View 1 chunk +39 lines, -0 lines 0 comments Download
A util/mac/launchd.mm View 1 chunk +137 lines, -0 lines 0 comments Download
A util/mac/launchd_test.mm View 1 chunk +292 lines, -0 lines 0 comments Download
A util/stdlib/objc.h View 1 chunk +39 lines, -0 lines 0 comments Download
M util/util.gyp View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
6 years, 4 months ago (2014-08-03 20:36:01 UTC) #1
Robert Sesek
LGTM
6 years, 4 months ago (2014-08-03 21:48:02 UTC) #2
Mark Mentovai
6 years, 4 months ago (2014-08-03 22:53:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 293964f69b8b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698