Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: content/renderer/media/webmediaplayer_impl.cc

Issue 438643002: media: Remove redundant DCHECK to check texture binding. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/webmediaplayer_impl.cc
diff --git a/content/renderer/media/webmediaplayer_impl.cc b/content/renderer/media/webmediaplayer_impl.cc
index 18aa02dc36bbfb2b529426c7c6e599d44415e6f7..09633bde08c4e972a6b4742d67ba4a5bf90ac9bd 100644
--- a/content/renderer/media/webmediaplayer_impl.cc
+++ b/content/renderer/media/webmediaplayer_impl.cc
@@ -616,18 +616,6 @@ bool WebMediaPlayerImpl::copyVideoTextureToPlatformTexture(
if (mailbox_holder->texture_target != GL_TEXTURE_2D)
return false;
- // Since this method changes which texture is bound to the TEXTURE_2D target,
- // ideally it would restore the currently-bound texture before returning.
- // The cost of getIntegerv is sufficiently high, however, that we want to
- // avoid it in user builds. As a result assume (below) that |texture| is
- // bound when this method is called, and only verify this fact when
- // DCHECK_IS_ON.
-#if DCHECK_IS_ON
- GLint bound_texture = 0;
- web_graphics_context->getIntegerv(GL_TEXTURE_BINDING_2D, &bound_texture);
- DCHECK_EQ(static_cast<GLuint>(bound_texture), texture);
-#endif
-
web_graphics_context->waitSyncPoint(mailbox_holder->sync_point);
uint32 source_texture = web_graphics_context->createAndConsumeTextureCHROMIUM(
GL_TEXTURE_2D, mailbox_holder->mailbox.name);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698