Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 438643002: media: Remove redundant DCHECK to check texture binding. (Closed)

Created:
6 years, 4 months ago by dshwang
Modified:
6 years, 4 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

media: Remove redundant DCHECK to check texture binding. After r284652 applying bindless variants mailbox produce/consume, WebMediaPlayerImpl::copyVideoTextureToPlatformTexture() doesn't change texture binding. So the given DCHECK becomes redundant. BUG=375501 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M content/renderer/media/webmediaplayer_impl.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
dshwang
Hi, could you review?
6 years, 4 months ago (2014-07-31 15:19:45 UTC) #1
no sievers
lgtm
6 years, 4 months ago (2014-07-31 16:13:14 UTC) #2
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 4 months ago (2014-07-31 16:30:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/438643002/1
6 years, 4 months ago (2014-07-31 16:31:57 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-31 18:06:14 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-31 18:09:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/1293)
6 years, 4 months ago (2014-07-31 18:09:36 UTC) #7
dshwang
On 2014/07/31 16:13:14, sievers wrote: > lgtm Thank you for lgtm. acolwell@, could you review ...
6 years, 4 months ago (2014-08-01 08:07:44 UTC) #8
acolwell GONE FROM CHROMIUM
lgtm
6 years, 4 months ago (2014-08-04 15:47:13 UTC) #9
dshwang
On 2014/08/04 15:47:13, acolwell wrote: > lgtm Thx!
6 years, 4 months ago (2014-08-04 15:48:34 UTC) #10
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 4 months ago (2014-08-04 15:48:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/438643002/1
6 years, 4 months ago (2014-08-04 15:49:24 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 15:53:03 UTC) #13
Message was sent while issue was closed.
Change committed as 287341

Powered by Google App Engine
This is Rietveld 408576698