Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 438533002: MacViews: Changes to allow app_list_unittests to compile (Closed)

Created:
6 years, 4 months ago by tapted
Modified:
6 years, 4 months ago
Reviewers:
calamity, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, mac-views-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

MacViews: Changes to allow app_list_unittests to compile It needs a better compositor setup for the tests to actually pass, but it compiles now. Changes were to fix the concept of "parent", which is a container aura::Window in Ash, and NULL on other platforms. However, the parent type for Widgets is a NativeView, not a NativeWindow. Gyp changes are required to resolve undefined symbols "ui::{Terminate,Initialize}ContextFactoryForTests()". This is called from ViewsTestBase in views_test_support, but views_test_support is missing the dependency on compositor_test_support where these are defined. On other platforms, this leaks in via aura stuff. BUG=365977, 399191 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287291

Patch Set 1 #

Patch Set 2 : fix gn #

Patch Set 3 : Fix Ash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M ui/app_list/views/app_list_main_view_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ui/app_list/views/app_list_view_unittest.cc View 1 2 4 chunks +13 lines, -5 lines 0 comments Download
M ui/views/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M ui/views/views.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
tapted
6 years, 4 months ago (2014-07-31 07:33:57 UTC) #1
tapted
fixed Ash - was hoping to avoid the #ifdef.. I think it could be done ...
6 years, 4 months ago (2014-07-31 08:20:50 UTC) #2
calamity
lgtm
6 years, 4 months ago (2014-08-04 02:36:06 UTC) #3
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 4 months ago (2014-08-04 02:49:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/438533002/40001
6 years, 4 months ago (2014-08-04 02:50:39 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-04 03:33:20 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-04 03:36:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/1765)
6 years, 4 months ago (2014-08-04 03:36:07 UTC) #8
tapted
+sky TBR for a trivial views.gyp change. This is just moving the compositor_test_support dependency from ...
6 years, 4 months ago (2014-08-04 03:39:36 UTC) #9
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 4 months ago (2014-08-04 03:40:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/438533002/40001
6 years, 4 months ago (2014-08-04 03:41:45 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 03:45:36 UTC) #12
Message was sent while issue was closed.
Change committed as 287291

Powered by Google App Engine
This is Rietveld 408576698